feat(manager): block gossiping misbehavior detection #1117
+1,402
−294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1117 +/- ##
==========================================
- Coverage 19.54% 18.63% -0.91%
==========================================
Files 165 168 +3
Lines 41268 44785 +3517
==========================================
+ Hits 8065 8346 +281
- Misses 32034 35232 +3198
- Partials 1169 1207 +38 ☔ View full report in Codecov by Sentry. |
srene
force-pushed
the
srene/1109-state-update-validation
branch
3 times, most recently
from
debc18c
to
fcd2eb0
Compare
| uerrors.ErrGroupGoLog(eg, m.logger, func() error { | ||
| return m.ValidateLoop(ctx) | ||
| }) | ||
| go uevent.MustSubscribe(ctx, m.Pubsub, "syncLoop", settlement.EventQueryNewSettlementBatchAccepted, m.onNewStateUpdate, m.logger) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
| return m.ValidateLoop(ctx) | ||
| }) | ||
| go uevent.MustSubscribe(ctx, m.Pubsub, "syncLoop", settlement.EventQueryNewSettlementBatchAccepted, m.onNewStateUpdate, m.logger) | ||
| go uevent.MustSubscribe(ctx, m.Pubsub, "validateLoop", settlement.EventQueryNewSettlementBatchFinalized, m.onNewStateUpdateFinalized, m.logger) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
srene
changed the base branch from
feat/adr-fraud-handling
to
srene/fix-test-p2p-validation
srene
force-pushed
the
srene/1109-state-update-validation
branch
from
7e8a12a
to
54d729b
Compare
srene
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
ADR: Optimistic Block Gossiping Misbehavior - Part 1
ADR: Optimistic Block Gossiping Misbehavior - Part 2
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close #1109 #1116
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: